rusackas commented on pull request #11854: URL: https://github.com/apache/incubator-superset/pull/11854#issuecomment-737550813
Adding on to @junlincc 's numbering system: 1) Agreed, let's fix that 2) Let's fix that *IF* it works in the current implementation. If not, let's file an issue and tackle that separately, so we can merge this one. 3) This is an enhancement, not addressed in the current solution. Let's file an issue and tackle that in a separate PR. 4) Easy fix, let's fix. 5) Just to clarify the scrolling business. I _do not_ think we should un-truncate that cell. JSON can be huuuuuuuuge, so we should set a reasonable max-width on any given cell, and truncate with ellipsis. BUT, if a result set has many columns, we should scroll horizontally to make sure you can see every column (each with that max-width applied). This is looking AWESOME, btw, super excited about this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
