kgabryje commented on a change in pull request #11854:
URL:
https://github.com/apache/incubator-superset/pull/11854#discussion_r535179400
##########
File path: superset-frontend/src/explore/components/ExploreChartPanel.jsx
##########
@@ -49,22 +52,124 @@ const propTypes = {
triggerRender: PropTypes.bool,
};
+export const EXPLORE_GUTTER_HEIGHT = 5;
Review comment:
I'm not sure about that. We use `EXPLORE_GUTTER_MARGIN` both in
component logic and in a styled component. In case we wanted to change its
value, we'd have to remember to modify 2 places instead of 1. Unless I passed
that margin value as a prop to styled component? We'd benefit from using a
theme variable, but I think we'd lose some readability. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
