villebro commented on a change in pull request #11885:
URL:
https://github.com/apache/incubator-superset/pull/11885#discussion_r535484521
##########
File path: superset-frontend/src/explore/components/controls/SelectControl.jsx
##########
@@ -102,10 +102,9 @@ export default class SelectControl extends
React.PureComponent {
// Beware: This is acting like an on-click instead of an on-change
// (firing every time user chooses vs firing only if a new option is chosen).
onChange(opt) {
- let optionValue = null;
+ let optionValue = this.props.multi ? [] : null;
Review comment:
One more thing - I might be missing something here, but I don't quite
get why this can't always be initialized to `[]`. @maloun96 can you check if
that works? I'd much rather not have a ternary here that can be avoided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
