mihir174 edited a comment on issue #11916:
URL: 
https://github.com/apache/incubator-superset/issues/11916#issuecomment-738289897


   @etr2460 Thanks for the quick feedback! I totally agree that the chart 
should have enough space.
   
   At these screen dimensions, the current panel has a width of 494px, and the 
proposed one is 576px (82px difference is about the length of the current `run` 
button for ref). 
   
   We still haven't finalized the area split between the chart and the data, so 
there is an opportunity to increase the chart size there - what do you think is 
a good min. size for the chart or ratio between chart and data table areas?
   
   Here's the main layout issue around a collapsable panel illustrated:
   
   SIP-34 Design-
   
   Expanded
   ![Screen Shot 2020-12-03 at 12 22 
1](https://user-images.githubusercontent.com/64227069/101084252-89ce5500-3562-11eb-8242-14eaaf10e3b8.png)
   
   Collapsed - the panel just slides to the left
   ![Screen Shot 2020-12-03 at 12 22 
2](https://user-images.githubusercontent.com/64227069/101084286-9783da80-3562-11eb-9bd0-2ebdedb561ef.png)
   
   This design (if we were to have the section collapse)-
   
   Expanded
   
![Expanded@2x](https://user-images.githubusercontent.com/64227069/101084324-a5d1f680-3562-11eb-9f43-4f0a9a61af55.png)
   
   Collapsed - the panel has to move under the datasource selector, which is a 
really awkward motion
   
![Collapsed@2x](https://user-images.githubusercontent.com/64227069/101084352-b1bdb880-3562-11eb-9b85-734079f8d241.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to