bkyryliuk commented on a change in pull request #11665:
URL:
https://github.com/apache/incubator-superset/pull/11665#discussion_r535616888
##########
File path: tests/annotation_layers/fixtures.py
##########
@@ -0,0 +1,101 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
this looks great, more common way to make fixtures available is to use
conftest:
https://www.tutorialspoint.com/pytest/pytest_conftest_py.htm
tests/annotation_layers/conftest.py - will make them automatically available
to all files in the modules and submodules
##########
File path: tests/charts/api_tests.py
##########
@@ -1383,3 +1386,44 @@ def test_import_chart_invalid(self):
assert response == {
"message": {"metadata.yaml": {"type": ["Must be equal to Slice."]}}
}
+
+ @pytest.mark.usefixtures("create_annotation_layers")
Review comment:
+1, some functions like login, get_table_by_name should be already
available as direct ( not object ) methods
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
