nytai commented on a change in pull request #11900:
URL:
https://github.com/apache/incubator-superset/pull/11900#discussion_r535636665
##########
File path: superset-frontend/src/views/CRUD/alert/AlertList.tsx
##########
@@ -275,6 +285,49 @@ function AlertList({
slot: canCreate ? EmptyStateButton : null,
};
+ const filters: Filters = useMemo(
+ () => [
+ {
+ Header: t('Created By'),
+ id: 'created_by',
+ input: 'select',
+ operator: 'rel_o_m',
Review comment:
I add these to an enum a recently
(https://github.com/apache/incubator-superset/blob/1842c56209131757f47bf7706a601aa933c6da4b/superset-frontend/src/components/ListView/types.ts#L103)
can we use that as we do in `QueryList` which should make their meaning a
little less ambiguous.
##########
File path: superset-frontend/src/views/CRUD/alert/AlertList.tsx
##########
@@ -275,6 +285,49 @@ function AlertList({
slot: canCreate ? EmptyStateButton : null,
};
+ const filters: Filters = useMemo(
+ () => [
+ {
+ Header: t('Created By'),
+ id: 'created_by',
+ input: 'select',
+ operator: 'rel_o_m',
+ unfilteredLabel: 'All',
+ fetchSelects: createFetchRelated(
+ 'report',
+ 'created_by',
+ createErrorHandler(errMsg =>
+ t(
+ 'An error occurred while fetching dataset datasource values: %s',
Review comment:
```suggestion
'An error occurred while fetching created by values: %s',
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
