john-bodley edited a comment on pull request #11714: URL: https://github.com/apache/incubator-superset/pull/11714#issuecomment-737573134
@mistercrunch, @dpgaspar, et al. would you be able to provide more as what the new fields added to the `logs` are (or will be) used for? The reason I ask is at Airbnb we use a MySQL database and the DDL operations locks the table which is problematic (especially for a large and frequently written to table like the `logs` table). Without planned downtime (possibly significant) the migration will not complete and the application is at risk of becoming inoperable (if/when a lock is obtained). Also did you consider using the `json` column for storing the extra metadata? This could be useful especially if these fields are experimental and no DB migration would be required. Finally storing the `path_no_int` (either via a column or in a JSON encoded string) seems somewhat kludgy as this could be easily obtained from the `path` field using regular expressions etc. which is available in most databases and would reduce the payload size. cc: @bkyryliuk (unsure if Dropbox uses MySQL). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
