etr2460 commented on pull request #11714:
URL: 
https://github.com/apache/incubator-superset/pull/11714#issuecomment-738453961


   @mistercrunch we have ~190 million events in the table currently, and while 
we may have a solution to migrate it, I think we've historically tried to avoid 
major changes to the logs table since migrations can be quite costly. The last 
migration before yours that touched the table was in 2018, and it already 
includes the `json` column where we could easily add any new metadata to here.
   
   If we do think the approach i mentioned here makes sense (putting your new 
fields in the json column). Then perhaps we can fix forward with a new 
migration, and include details on how to skip past the 2 migrations adding and 
removing the new columns in UPDATING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to