mistercrunch commented on a change in pull request #11899:
URL:
https://github.com/apache/incubator-superset/pull/11899#discussion_r535853325
##########
File path: superset-frontend/stylesheets/less/cosmo/variables.less
##########
@@ -751,24 +751,6 @@
@well-bg: @gray-bg; // superset-var
@well-border: darken(@well-bg, 7%);
-// == Badges
-//
-// ##
-
-@badge-color: @lightest; // superset-var
-// ** Linked badge text color on hover
-@badge-link-hover-color: @lightest; // superset-var
-@badge-bg: @brand-primary;
-
-// ** Badge text color in active nav link
-@badge-active-color: @link-color;
-// ** Badge background color in active nav link
-@badge-active-bg: @lightest; // superset-var
-
-@badge-font-weight: bold;
-@badge-line-height: 1;
-@badge-border-radius: 10px;
-
Review comment:
I think it's ok to remove this, but generally I'd keep the theme intact
for where FAB is used (the goal is to remove all of the FAB templates, but
there are still some CRUD pages that are FAB-powered, and if they have a
bootstrap badge they'll won't be themed)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
