rusackas opened a new pull request #11926: URL: https://github.com/apache/incubator-superset/pull/11926
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> I happened to notice a few files were directly using the `supersetTheme` from `superset-ui` directly. It's better to use the theme inherited via the `ThemeProvider` at the top of the React apps, so that we can mutate/override/append that base `supersetTheme` at the provider level, and have all the react components inherit that theme properly. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> (should be no visible change at this point) ### TEST PLAN <!--- What steps should be taken to verify the changes --> @junlincc and I will poke around to make sure nothing looks out of place. And CI should pass, of course. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
