mistercrunch commented on a change in pull request #11934:
URL:
https://github.com/apache/incubator-superset/pull/11934#discussion_r536283697
##########
File path: superset/dao/base.py
##########
@@ -76,6 +76,19 @@ def find_by_ids(cls, model_ids: List[int]) -> List[Model]:
).apply(query, None)
return query.all()
+ @classmethod
+ def find_all(cls) -> List[Model]:
Review comment:
I know this is very similar to `find_by_ids` but decided to go explicit
over dry. We're already pretty meta here so didn't want to add a layer to safe
a few lines of code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
