ktmud commented on a change in pull request #11687:
URL:
https://github.com/apache/incubator-superset/pull/11687#discussion_r537982180
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx
##########
@@ -67,13 +67,11 @@ function DashboardCard({
const menu = (
<Menu>
- {canEdit && openDashboardEditModal && (
+ {canEdit && handleDashboardEdit && (
<Menu.Item
role="button"
tabIndex={0}
- onClick={() =>
- openDashboardEditModal && openDashboardEditModal(dashboard)
- }
+ onClick={() => handleDashboardEdit && handleDashboardEdit(dashboard)}
Review comment:
With that said, I don't think opening in a new tab matters that much in
this case. But just FYI, Tableau opens the Edit link in thumbnail dropdowns in
a new tab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
