villebro commented on a change in pull request #11880:
URL:
https://github.com/apache/incubator-superset/pull/11880#discussion_r538104882
##########
File path: superset-frontend/src/dashboard/components/FiltersBadge/selectors.ts
##########
@@ -132,12 +132,12 @@ export const selectIndicatorsForChart = (
// for now we only need to know which columns are compatible/incompatible,
// so grab the columns from the applied/rejected filters
const appliedColumns: Set<string> = new Set(
- (chart?.queryResponse?.applied_filters || []).map(
+ (chart?.queriesResponse?.[0]?.applied_filters || []).map(
Review comment:
> If a chart makes multiple queries, it would probably be more correct
to add the `applied_filters` and `rejected_filters` from each of the queries,
instead of just the first one. But that really depends on how dashboard filters
works with multiple queries.
I think we should probably be applying the same filters to all
`QueryObject`s. Since a `QueryContext` currently only supports a single
datasource, the applied/rejected columns should be identical. However, temporal
filters will only be applicable for `QueryObject`s with `is_temporal: true`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
