graceguo-supercat commented on a change in pull request #11814:
URL:
https://github.com/apache/incubator-superset/pull/11814#discussion_r538145449
##########
File path: superset-frontend/src/explore/actions/exploreActions.ts
##########
@@ -86,7 +86,7 @@ export function fetchFaveStar(sliceId: string) {
export const SAVE_FAVE_STAR = 'SAVE_FAVE_STAR';
export function saveFaveStar(sliceId: string, isStarred: boolean) {
- return function (dispatch: Dispatch<ReturnType<typeof addDangerToast>>) {
+ return function (dispatch: Dispatch) {
Review comment:
why do you remove return type?
##########
File path: superset-frontend/src/explore/actions/exploreActions.ts
##########
@@ -86,7 +86,7 @@ export function fetchFaveStar(sliceId: string) {
export const SAVE_FAVE_STAR = 'SAVE_FAVE_STAR';
export function saveFaveStar(sliceId: string, isStarred: boolean) {
- return function (dispatch: Dispatch<ReturnType<typeof addDangerToast>>) {
+ return function (dispatch: Dispatch) {
Review comment:
why remove return type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
