ktmud commented on a change in pull request #11755:
URL:
https://github.com/apache/incubator-superset/pull/11755#discussion_r538090680
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -87,6 +122,16 @@ export default class ResultSet extends React.PureComponent<
searchText: '',
showExploreResultsButton: false,
data: [],
+ showSaveDatasetModal: false,
+ newSaveDatasetName: `${props.query.tab} ${moment().format(
+ 'MM/DD/YYYY HH:mm:ss',
+ )}`,
+ userDatasetsOwned: [],
+ saveDatasetRadioBtnState: DatasetRadioState.SAVE_NEW,
+ shouldOverwriteDataSet: false,
+ datasetToOverwrite: {},
+ saveModalAutocompleteValue: '',
+ userDatasetOptions: [],
Review comment:
I feel you may be passing too many states between components
unnecessarily. Can these be combined into one construct as the modal's local
states and only be passed up to the parent component when users hit "Save"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
