ktmud edited a comment on pull request #11883: URL: https://github.com/apache/incubator-superset/pull/11883#issuecomment-741153781
@villebro then is this PR good for merge as is or do you prefer moving the enums to `typing` or `constants`? I don't have a strong opinion on either, but I'd like to point out Enums exist before Python had typing and by then they would normally be put into constants. For a language where typing is optional, we would probably want the program to run even without typing. TypeScript enums are types because JavaScript doesn't have native Enums. But since it's unlikely we are going to remove Python typing for Superset anyway, so I'm Ok with treating them as types as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
