rusackas commented on a change in pull request #11951:
URL:
https://github.com/apache/incubator-superset/pull/11951#discussion_r539087305
##########
File path: superset-frontend/src/components/Checkbox/index.tsx
##########
@@ -25,8 +25,8 @@ import {
interface CheckboxProps {
checked: boolean;
- onChange: (val?: boolean) => {};
- style: object;
+ onChange: (val?: boolean) => void;
+ style?: object;
Review comment:
_If_ it _is_ intentional (I'm not sure either), it'd be the only
remaining instance of `object` so maybe we can touch that up too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
