riahk commented on a change in pull request #11770:
URL:
https://github.com/apache/incubator-superset/pull/11770#discussion_r539540878
##########
File path: superset/reports/commands/update.py
##########
@@ -87,6 +88,11 @@ def validate(self) -> None:
# Validate chart or dashboard relations
self.validate_chart_dashboard(exceptions, update=True)
+ if "validator_config_json" in self._properties:
+ self._properties["validator_config_json"] = json.dumps(
+ self._properties["validator_config_json"]
+ )
+
Review comment:
@dpgaspar added this logic to make it easier for the FE (you can see it
in the `create` logic already), by not requiring us to stringify our json
beforehand, which I'm fine with. Do you see it as being an issue in the long
run?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
