nytai commented on a change in pull request #11770:
URL:
https://github.com/apache/incubator-superset/pull/11770#discussion_r539544023
##########
File path: superset/reports/commands/update.py
##########
@@ -87,6 +88,11 @@ def validate(self) -> None:
# Validate chart or dashboard relations
self.validate_chart_dashboard(exceptions, update=True)
+ if "validator_config_json" in self._properties:
+ self._properties["validator_config_json"] = json.dumps(
+ self._properties["validator_config_json"]
+ )
+
Review comment:
My main concern is with the api spec (ie, `/swagger/v1`). If it
specifies a json string for this field a user will likely make an api request
with a json string and possibly encounter a opaque error message from the api
server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
