dpgaspar commented on a change in pull request #11770:
URL:
https://github.com/apache/incubator-superset/pull/11770#discussion_r539547385
##########
File path: superset/reports/commands/update.py
##########
@@ -87,6 +88,11 @@ def validate(self) -> None:
# Validate chart or dashboard relations
self.validate_chart_dashboard(exceptions, update=True)
+ if "validator_config_json" in self._properties:
+ self._properties["validator_config_json"] = json.dumps(
+ self._properties["validator_config_json"]
+ )
+
Review comment:
I think that the OpenAPI spec is clear on this, it's just a nested
structure, this happens on other places also. I think it's more elegant then
sending a JSON string for a specific field
<img width="732" alt="Screenshot 2020-12-09 at 18 28 46"
src="https://user-images.githubusercontent.com/4025227/101671716-c27f9a00-3a4c-11eb-80fa-0f7427d3d019.png";>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/4025227/101671716-c27f9a00-3a4c-11eb-80fa-0f7427d3d019.png"](https://user-images.githubusercontent.com/4025227/101671716-c27f9a00-3a4c-11eb-80fa-0f7427d3d019.png"){kind=link}