etr2460 commented on a change in pull request #11951:
URL:
https://github.com/apache/incubator-superset/pull/11951#discussion_r539585411
##########
File path: superset-frontend/src/dashboard/components/SaveModal.tsx
##########
@@ -185,7 +207,7 @@ class SaveModal extends React.PureComponent {
<div className="m-l-25 m-t-5">
<Checkbox
checked={this.state.duplicateSlices}
- onChange={this.toggleDuplicateSlices}
+ onChange={() => this.toggleDuplicateSlices}
Review comment:
wondering why this was needed, seems like it might break it (not that
toggleDuplicateSlices isn't actually being called I think)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
