betodealmeida opened a new pull request #11987:
URL: https://github.com/apache/incubator-superset/pull/11987
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
When deleting an asset we ask the user for confirmation with this phrase:
```js
t('type "delete" to confirm')
```
Which in Portuguese, eg, translates to _**digite "apagar" para confirmar**_.
But if the user types in "apagar" it won't work. :-P
This PR fixes the bug by comparing the user input with the translated
version of "delete".
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
N/A
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
There are currently no translations for the strings, so I couldn't test in a
different language. But confirmed that it still works in English.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
