suddjian commented on pull request #11814: URL: https://github.com/apache/incubator-superset/pull/11814#issuecomment-742137487
Thanks for the review, @ktmud! > I think in the future, we could benefit from using a feature branch for changes as big as this one. Changes will be merged into a feature branch incrementally, so we can have smaller PRs to review and iterate faster while still keeping master stable. That's kind of how we approached much this. We had folks open PRs onto the `dashboard-native-filters` branch in the Preset fork. But the reality when doing that is a lot of broken parts end up getting merged to unblock people. It's my first time trying that development style though, and I'd like to get better at it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
