nytai commented on a change in pull request #11937:
URL:
https://github.com/apache/incubator-superset/pull/11937#discussion_r539752751
##########
File path: superset-frontend/src/views/CRUD/alert/AlertList.tsx
##########
@@ -217,16 +167,20 @@ function AlertList({
},
{
Cell: ({ row: { original } }: any) => {
+ const history = useHistory();
const handleEdit = () => {}; // handleAnnotationEdit(original);
const handleDelete = () => {}; //
setAlertCurrentlyDeleting(original);
+ const hanldeGotoExecutionLog = () =>
Review comment:
```suggestion
const handleGotoExecutionLog = () =>
```
##########
File path: superset-frontend/src/views/CRUD/alert/AlertList.tsx
##########
@@ -217,16 +167,20 @@ function AlertList({
},
{
Cell: ({ row: { original } }: any) => {
+ const history = useHistory();
const handleEdit = () => {}; // handleAnnotationEdit(original);
const handleDelete = () => {}; //
setAlertCurrentlyDeleting(original);
+ const hanldeGotoExecutionLog = () =>
+ history.push(`/${original.type.toLowerCase()}/${original.id}/log`);
+
const actions = [
canEdit
? {
- label: 'preview-action',
+ label: 'execution-log-action',
tooltip: t('Execution Log'),
placement: 'bottom',
icon: 'note' as IconName,
- onClick: handleEdit,
+ onClick: hanldeGotoExecutionLog,
Review comment:
```suggestion
onClick: handleGotoExecutionLog,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
