eschutho commented on a change in pull request #11936:
URL:
https://github.com/apache/incubator-superset/pull/11936#discussion_r540390892
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -568,12 +570,22 @@ function ChartList(props: ChartListProps) {
}}
</ConfirmStatusChange>
- <ImportChartModal
- show={importingChart}
- onHide={closeChartImportModal}
+ <ImportModelsModal
+ resourceName="chart"
+ resourceLabel={t('chart')}
+ icon={<StyledIcon name="nav-charts" />}
+ passwordsNeededMessage={t(
+ 'The passwords for the databases below are needed in order to ' +
+ 'import them together with the charts. Please note that the ' +
+ '"Secure Extra" and "Certificate" sections of ' +
+ 'the database configuration are not present in export files, and '
+
+ 'should be added manually after the import if they are needed.',
+ )}
addDangerToast={addDangerToast}
addSuccessToast={addSuccessToast}
- onChartImport={handleChartImport}
+ onModelImport={handleChartImport}
+ show={importingChart}
+ onHide={closeChartImportModal}
Review comment:
TBH, we used inline functions all the time in the past, so I never gave
that concern much weight.. I've heard arguments for/against, but I will
research the latest stance on this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
