hughhhh commented on a change in pull request #11983:
URL:
https://github.com/apache/incubator-superset/pull/11983#discussion_r541133446
##########
File path: superset-frontend/src/views/CRUD/chart/ChartList.tsx
##########
@@ -581,6 +581,9 @@ function ChartList(props: ChartListProps) {
'the database configuration are not present in export files, and '
+
'should be added manually after the import if they are needed.',
)}
+ confirmOverwriteMessage={t(
+ 'One or more charts to be imported already exist.',
Review comment:
we could make this more modular by making the message live in the
component and change the resource name. For example, `One or more
{resourceName} to be imported already exist.` then we wouldn't have to pass the
message through the props
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
