[GitHub] [incubator-superset] zuzana-vej opened a new issue #11380: Datasource edit doesn't save schema, only saves new dataset name

[GitBox]

zuzana-vej opened a new issue #11380:
URL: https://github.com/apache/incubator-superset/issues/11380


   On chart explore, when you click on change dataset, and try to edit the 
datasource (table) name, the table name change works as expected but unless you 
edit schema, the existing schema doesn't get saved causing the chart to break.
   
   ### Expected results
   
   Both schema and table name should change.
   
   ### Actual results
   
   Only table name changes.
   
   #### Screenshots
   
   Step 1: my table name (before change)
   <img width="289" alt="Screen Shot 2020-10-21 at 6 38 34 PM" 
src="https://user-images.githubusercontent.com/61221714/96808094-0222f180-13cd-11eb-822a-5e319c1242cf.png";>
   
   Step 2: try to edit table name, schema is same - do not edit schema
   <img width="716" alt="Screen Shot 2020-10-21 at 6 37 46 PM" 
src="https://user-images.githubusercontent.com/61221714/96808122-0f3fe080-13cd-11eb-86c0-b0d42960ead1.png";>
   
   
   Step 3: This is the result: New table name is displayed with NO SCHEMA. if 
you run chart, it breaks.
   <img width="365" alt="Screen Shot 2020-10-21 at 6 37 53 PM" 
src="https://user-images.githubusercontent.com/61221714/96808138-1b2ba280-13cd-11eb-8530-0b7e6221ee20.png";>
   
   
   #### How to reproduce the bug
   
   1. Go to 'Chart Explore'
   2. Click on 'Change Dataset'
   3. Enter new table name, keep same schema
   4. Click on Save
   5. See issue
   
   ### Environment
   
   (please complete the following information):
   
   - superset version: master
   ### Checklist
   
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version 
of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org