[GitHub] [incubator-superset] junlincc commented on pull request #11993: refactor : Change menu name and reorder items

[GitBox]

junlincc commented on pull request #11993:
URL: 
https://github.com/apache/incubator-superset/pull/11993#issuecomment-743694009


   @maloun96 Thanks for fixing the typo. 
   **NEW AFTER**
   <img width="200" alt="Screen Shot 2020-12-11 at 7 01 35 PM" 
src="https://user-images.githubusercontent.com/67837651/101971362-af540200-3be5-11eb-83f1-f34d259d8b06.png";>
   
   However, the instruction in Trello is below -  capitalizing each word 
   View Chart in Explore
   Share Chart
   Maximize Chart
   Download as Image
   Export CSV
   
   I scanned through most of the menuitem in Superset and the casing is a MESS 
across the product... 
   is there a standard for capitalizing (or not capitalizing) each word in the 
menuitem? if not, we SHOULD have one  @mihir174 
   
   <img width="155" alt="Screen Shot 2020-12-11 at 7 17 03 PM" 
src="https://user-images.githubusercontent.com/67837651/101971442-35704880-3be6-11eb-88c4-1bd1c70c1098.png";>
   <img width="165" alt="Screen Shot 2020-12-11 at 7 16 38 PM" 
src="https://user-images.githubusercontent.com/67837651/101971446-386b3900-3be6-11eb-871c-03240f40af1c.png";>
   <img width="163" alt="Screen Shot 2020-12-11 at 7 17 08 PM" 
src="https://user-images.githubusercontent.com/67837651/101971451-3ef9b080-3be6-11eb-908b-c2dd292e5fec.png";>
   <img width="245" alt="Screen Shot 2020-12-11 at 7 21 55 PM" 
src="https://user-images.githubusercontent.com/67837651/101971455-4325ce00-3be6-11eb-9301-7b2fdc0f721d.png";>
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org