betodealmeida opened a new pull request #12026:
URL: https://github.com/apache/incubator-superset/pull/12026


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Currently the examples that come with Superset are all generated by Python 
scripts, making modifying the existing examples or creating new ones 
unnecessarily complicated.
   
   With the new export/import functionality from 
[SIP-54](https://github.com/apache/incubator-superset/issues/11167) we can 
store the examples in the repo as YAML files instead of code. This way the 
examples can be easily modified, and new examples can be created inside 
Superset, exported and added to the repo.
   
   In this PR I moved the "Unicode test" example to YAML files. Doing so 
required a few modifications, namely, adding a `data` attribute to the dataset 
config pointing to a URL where the data can be download as a CSV. This is 
similar to how `load_examples` currently work, with the difference that we 
don't know the column types a priori, so they need to be inferred from the 
dataset metadata.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   N/A
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   I loaded the examples, and verified that the unicode test is imported and 
set up correctly.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to