[GitHub] [incubator-superset] nytai opened a new pull request #12032: feat: add cron picker to AlertReportModal

[GitBox]

nytai opened a new pull request #12032:
URL: https://github.com/apache/incubator-superset/pull/12032


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   - adds a cron picker based on `react-js-cron` to the AlertReportModal
   - adds a storybook entry for `react-js-cron` example usage with a free-form 
input. 
   - fixes flex-wrap style at lower screen widths
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   After:
   <img width="1669" alt="Screen Shot 2020-12-13 at 10 19 38 PM" 
src="https://user-images.githubusercontent.com/10255196/102047080-7f496200-3d91-11eb-95dc-a25be78313b0.png";>
   <img width="1674" alt="Screen Shot 2020-12-13 at 10 20 03 PM" 
src="https://user-images.githubusercontent.com/10255196/102047091-82dce900-3d91-11eb-911e-9641e7f40cd3.png";>
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - manual testing
     - AlertReportModal contains a cron picker
     - changes to cron picker are reflected in the text input. 
     - changes to text input, followed by a blur or entry key, are reflected in 
cron-picker  
   - storybook component testing.
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Changes UI
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org