kgabryje opened a new pull request #12042:
URL: https://github.com/apache/incubator-superset/pull/12042


   ### SUMMARY
   As a first part of 
https://github.com/apache/incubator-superset/issues/11916, I migrated 
react-select components in Filters and Metrics popovers to Antd. Next step will 
be refactoring MetricsControl and AdhocFiltersControl according to designs.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   As you can see on the before/after screenshot, there is 1 difference - in 
the bottom select input we no longer display placeholder that says how many 
options are left when there's at least 1 option selected. Antd doesn't support 
displaying such label.
   
   Before:
   
![image](https://user-images.githubusercontent.com/15073128/102120398-c6436000-3e42-11eb-9232-60e9d19d0c85.png)
   After: 
   
![image](https://user-images.githubusercontent.com/15073128/102120349-b592ea00-3e42-11eb-9215-c195e7ef89c1.png)
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   CC: @junlincc @villebro @adam-stasiak 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to