ktmud commented on a change in pull request #11970:
URL:
https://github.com/apache/incubator-superset/pull/11970#discussion_r543042197
##########
File path: superset/connectors/sqla/models.py
##########
@@ -1467,6 +1469,26 @@ class and any keys added via `ExtraCache`.
extra_cache_keys += sqla_query.extra_cache_keys
return extra_cache_keys
+ @event_logger.log_this
Review comment:
What you care most is the actual check function, the part where we check
version and skip the health check (happens for most page views) is known to be
pretty trivial. So maybe use this code instead:
```python
with event_logger.log_context(action="datasource_health_check") as log:
message = check(self)
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
