nikolagigic commented on a change in pull request #11979:
URL:
https://github.com/apache/incubator-superset/pull/11979#discussion_r543599156
##########
File path: superset-frontend/spec/javascripts/explore/utils_spec.jsx
##########
@@ -200,6 +201,25 @@ describe('exploreUtils', () => {
});
});
+ describe('columnCount', () => {
+ it('divides samples data into pages of 20', () => {
+ const pageSize = columnCount(500);
+ expect(pageSize).toEqual(20);
+ });
+ it('divides samples data into pages of 20', () => {
+ const pageSize = columnCount(0);
+ expect(pageSize).toEqual(50);
+ });
+ it('divides samples data into pages of 20', () => {
+ const pageSize = columnCount(1);
+ expect(pageSize).toEqual(10000);
+ });
+ it('divides samples data into pages of 20', () => {
+ const pageSize = columnCount(1000000);
+ expect(pageSize).toEqual(5);
+ });
+ });
Review comment:
yep, forgot to change the description. Will move it under one `it`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
