betodealmeida opened a new pull request #12064:
URL: https://github.com/apache/incubator-superset/pull/12064


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This PR includes a few small fixes to the import/export feature:
   
   1. Micro optimizations: some JSON fields may be empty strings, so we only 
serialize/deserialize them if they have an actual document.
   2. Fixes: I was checking for the wrong exception when dumping JSON to a 
string (copy-and-paste mistakes, sigh).
   3. Deserialize more fields: some of the fields that had a JSON payload were 
not being deserialized when exporting to YAML.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   N/A
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   Unit tests green
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to