ktmud edited a comment on pull request #9962: URL: https://github.com/apache/incubator-superset/pull/9962#issuecomment-655791527
Hi @villebro @rusackas , I was migrating table chart to use the new API. The more I look at it, the more I feel there shouldn't be the need to include this `queryFields` mapping to `formData`. The information about field mapping is at the visualization type level, and isn't a variable per visualization. `formData` will be stored in database and passed around in the URL and the URL is already a mess, we should keep it as simple as possible. There is already a `buildQuery` hook for visualization plugins, maybe that's a better place for this type of custom mapping logics? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
