etr2460 commented on a change in pull request #11976:
URL:
https://github.com/apache/incubator-superset/pull/11976#discussion_r544425761
##########
File path: superset-frontend/src/dashboard/components/RefreshIntervalModal.tsx
##########
@@ -104,7 +112,7 @@ class RefreshIntervalModal extends React.PureComponent {
<FormLabel>{t('Refresh frequency')}</FormLabel>
<Select
options={options}
- value={this.state.refreshFrequency}
+ value={options.find(({ value }) => value === refreshFrequency)}
Review comment:
can you include a test plan showing that everything still works as
intended after this change?
Perhaps it might be better to construct an option object here instead of
finding it from the options array, but I don't have a strong feeling one way or
another.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
