etr2460 commented on a change in pull request #11997:
URL:
https://github.com/apache/incubator-superset/pull/11997#discussion_r544433101
##########
File path: superset-frontend/src/explore/components/SaveModal.tsx
##########
@@ -227,7 +240,8 @@ class SaveModal extends React.Component {
onChange={this.onDashboardSelectChange}
autoSize={false}
value={
- this.state.saveToDashboardId || this.state.newDashboardName
+ (this.state.saveToDashboardId ||
+ this.state.newDashboardName) as ValueType<Record<string,
any>>
Review comment:
After further discussion, is this the same option issue as before too?
Maybe we should construct an option object to pass in here instead of only
passing in the string
##########
File path: superset-frontend/src/explore/components/SaveModal.tsx
##########
@@ -132,6 +147,8 @@ class SaveModal extends React.Component {
}
render() {
+ console.log('this.state.saveToDashboardId', this.state.saveToDashboardId);
+ console.log('this.state.newDashboardName', this.state.newDashboardName);
Review comment:
remove the console logs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
