ktmud opened a new pull request #12074:
URL: https://github.com/apache/incubator-superset/pull/12074


   ### SUMMARY
   
   Sometimes when `@superset-ui/core` or `@superset-ui/chart-controls` install 
an incompatible version of `@types/react` (from dependency chains), builds with 
`npm link` will throw typing errors. 
   
   This tsconfig update fixes these errors following the advice from 
https://github.com/Microsoft/typescript/issues/6496#issuecomment-384786222
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A
   
   ### TEST PLAN
   
   `npm link /source/code/to/superset-ui-core` and `npm run dev` should not 
throw typing errors.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to