robdiciuccio commented on a change in pull request #12079:
URL:
https://github.com/apache/incubator-superset/pull/12079#discussion_r544599388
##########
File path: requirements/testing.txt
##########
@@ -35,9 +35,9 @@ pyhive[hive,presto]==0.6.3 # via -r
requirements/development.in, -r requirement
pylint==2.6.0 # via -r requirements/testing.in
pytest-cov==2.10.1 # via -r requirements/testing.in
pytest==6.1.2 # via -r requirements/testing.in, pytest-cov
-redis==3.5.3 # via -r requirements/testing.in
Review comment:
Redis is currently required for running tests.
##########
File path: requirements/testing.txt
##########
@@ -35,9 +35,9 @@ pyhive[hive,presto]==0.6.3 # via -r
requirements/development.in, -r requirement
pylint==2.6.0 # via -r requirements/testing.in
pytest-cov==2.10.1 # via -r requirements/testing.in
pytest==6.1.2 # via -r requirements/testing.in, pytest-cov
-redis==3.5.3 # via -r requirements/testing.in
Review comment:
Redis is [currently
required](https://github.com/preset-io/incubator-superset/blob/master/tests/superset_test_config.py#L87)
for running tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
