graceguo-supercat edited a comment on pull request #11960: URL: https://github.com/apache/incubator-superset/pull/11960#issuecomment-747123333
Click-edit chart title is correct behavior: - when you done edit, title change is front-end only, it is not saved to database. - when you open Save Modal, the changed title will show in the Save Modal. - when you click on Save button, title change will be saved to database. We had this behavior for a long time (before Properties Modal exists). Why do we want to change this behavior? I think the problem is the Properties Modal: chart title and Save Modal all read/update content from redux store, while Properties Modal didn't. That's the reason its content is always out of sync with global redux store. Please check how redux work in explore view. Or, you can remove edit chart title from Properties Modal. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
