nytai commented on a change in pull request #12071: URL: https://github.com/apache/incubator-superset/pull/12071#discussion_r544814339
########## File path: superset-frontend/src/components/LastUpdated/index.tsx ########## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React, { useEffect, useState, FunctionComponent } from 'react'; +import moment from 'moment'; +import { t, styled } from '@superset-ui/core'; +import Icon from 'src/components/Icon'; + +const REFRESH_INTERVAL = 60000; // every minute + +interface LastUpdatedProps { + updatedAt: string | Date | number; + update?: React.MouseEventHandler<SVGSVGElement>; +} +moment.updateLocale('en', { Review comment: We do set the locale when apps start up, https://github.com/preset-io/incubator-superset/blob/037c7e24df2cd75ed714f2f56875ce84137ae6fe/superset-frontend/src/preamble.ts#L40 This just changes the way some things are displayed in the english locale, mainly showing time with seconds when formatting timestamps as calendar format. The seconds granularity is desired so refreshes that happen in the same second actually see a change in the UI. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
