ktmud commented on a change in pull request #11418:
URL:
https://github.com/apache/incubator-superset/pull/11418#discussion_r545404057
##########
File path: superset/utils/core.py
##########
@@ -1231,7 +1246,205 @@ def ensure_path_exists(path: str) -> None:
raise
-def get_since_until( # pylint: disable=too-many-arguments
+class EvalText: # pylint: disable=too-few-public-methods
Review comment:
Can we move these classes/functions to a new file? E.g.
`superset/utils/time_range.py`
The `core.py` file already quite large and we start breaking it up instead
of adding new things to it.
##########
File path: superset/utils/core.py
##########
@@ -1231,7 +1246,205 @@ def ensure_path_exists(path: str) -> None:
raise
-def get_since_until( # pylint: disable=too-many-arguments
+class EvalText: # pylint: disable=too-few-public-methods
Review comment:
Can we move these classes/functions to a new file? E.g.
`superset/utils/time_range.py`
The `core.py` file already quite large and we should start breaking it up
instead of adding new things to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
