zhaoyongjie commented on a change in pull request #11418:
URL:
https://github.com/apache/incubator-superset/pull/11418#discussion_r545407860
##########
File path: superset/utils/core.py
##########
@@ -1231,7 +1246,205 @@ def ensure_path_exists(path: str) -> None:
raise
-def get_since_until( # pylint: disable=too-many-arguments
+class EvalText: # pylint: disable=too-few-public-methods
Review comment:
I'm having some trouble with circular imports. :( `utils.core` does need
to be broken down, I can help with some of the this work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
