eschutho commented on a change in pull request #12087:
URL:
https://github.com/apache/incubator-superset/pull/12087#discussion_r545522581
##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -613,6 +630,9 @@ class SqlEditor extends React.PureComponent {
isRunning={this.props.latestQuery.state === 'running'}
/>
)}
+ <Dropdown overlay={this.renderDropdown()} arrow>
Review comment:
It looks like `Dropdown` takes either a Node or a method, so you could
pass it just the method as the overlay, and leave it up to ant to decide when
to rerun the method. Otherwise, I think it's going to run on each re-render.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
