nytai opened a new pull request #12110: URL: https://github.com/apache/incubator-superset/pull/12110
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Fixes a few issues with alerts: - Add button is disabled for both the alerts and reports modal when all required fields are filled - The "Add Report" modal field has label and helper text "Add Alert" and section header "Alert Condition Schedule". Let's change these to "Add Report" and "Report Schedule" - Switch over select apis to use `/api/v1/related/<chart|dashboard|database|owners>` - expose `api/v1/report/related/created_by` api ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> After: <img width="838" alt="Screen Shot 2020-12-17 at 10 10 44 PM" src="https://user-images.githubusercontent.com/10255196/102581143-d06c9500-40b4-11eb-91e5-9bd920b40e9b.png";> ### TEST PLAN <!--- What steps should be taken to verify the changes --> - manual test: - Modal submit button is enabled after all required fields have been filled - Report modal has copy updated `alert -> report` - select values are fetched from `/api/v1/report/related/*` endpoints. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/10255196/102581143-d06c9500-40b4-11eb-91e5-9bd920b40e9b.png"](https://user-images.githubusercontent.com/10255196/102581143-d06c9500-40b4-11eb-91e5-9bd920b40e9b.png"){kind=link}