ktmud opened a new pull request #12114: URL: https://github.com/apache/incubator-superset/pull/12114
### SUMMARY After recent upgrades of Redux (#11967 ), FilterBox selects would lose focus once users focused on it, making it impossible to type to search filter values. This is caused by some unnecessary rendering. Fixed by moving FilterBox component to `React.PureComponent`. Didn't dig deep, but my guess is this is because new Redux now will re-render components even if props are all the same. Fixes #12105. This should have been caught by the FilterBox test case had it been enabled. Maybe previously it was flaky because of the same reason. Let's see if re-enable it gives us any luck this time. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A ### TEST PLAN <!--- What steps should be taken to verify the changes --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API cc @junlincc @graceguo-supercat @zuzana-vej ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
