[GitHub] [incubator-superset] michael-s-molina opened a new pull request #12122: refactor: Migrate Bootstrap Alert to AntD (#12101)

[GitBox]

michael-s-molina opened a new pull request #12122:
URL: https://github.com/apache/incubator-superset/pull/12122


   ### SUMMARY
   Migrates Alert component from Bootstrap to AntD.
   
   ### BEFORE/AFTER SCREENSHOTS
   <img width="1783" alt="1-before" 
src="https://user-images.githubusercontent.com/70410625/102625920-eb76ed80-4124-11eb-993e-84487a470393.png";>
   <img width="1786" alt="1-after" 
src="https://user-images.githubusercontent.com/70410625/102636519-824aa680-4133-11eb-89f0-b5d732800943.png";>
   <img width="862" alt="2-before" 
src="https://user-images.githubusercontent.com/70410625/102629558-131c8480-412a-11eb-8d46-1029f358c5c2.png";>
   <img width="857" alt="2-after" 
src="https://user-images.githubusercontent.com/70410625/102629574-16b00b80-412a-11eb-8f1d-14523e462033.png";>
   <img width="408" alt="3-before" 
src="https://user-images.githubusercontent.com/70410625/102625932-edd94780-4124-11eb-9caf-d155f166d408.png";>
   <img width="404" alt="3-after" 
src="https://user-images.githubusercontent.com/70410625/102629595-1ca5ec80-412a-11eb-94ed-5ff1b07b8d7d.png";>
   
   `Toast` had a dependency on `Alert`. I removed this dependency by emulating 
the same behavior with a styled `div`. I also added an icon for every status.
   
   <img width="249" alt="toast-error" 
src="https://user-images.githubusercontent.com/70410625/102625935-ee71de00-4124-11eb-8dbf-4874dc6dabe5.png";>
   <img width="242" alt="toast-info" 
src="https://user-images.githubusercontent.com/70410625/102625936-ef0a7480-4124-11eb-8d6c-6687ce7e8d2a.png";>
   <img width="270" alt="toast-success" 
src="https://user-images.githubusercontent.com/70410625/102625938-ef0a7480-4124-11eb-9597-bf11340eff7f.png";>
   <img width="275" alt="toast-warning" 
src="https://user-images.githubusercontent.com/70410625/102625940-efa30b00-4124-11eb-9791-acc639aef8e1.png";>
   
    We should consider replacing `Toast` code with AntD 
[Notification](https://ant.design/components/notification/).
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org