[GitHub] [incubator-superset] junlincc commented on pull request #12123: feat: Add Saved Metrics tab to metrics popover

[GitBox]

junlincc commented on pull request #12123:
URL: 
https://github.com/apache/incubator-superset/pull/12123#issuecomment-748245343


   Thank you so much for this PR! it's looking great! 
   
   minor issue: overflow when resizing
   <img width="239" alt="Screen Shot 2020-12-18 at 10 11 11 AM" 
src="https://user-images.githubusercontent.com/67837651/102646805-89fd5180-4119-11eb-9097-a18d1c9af46d.png";>
   
   not related to this PR - the styling of the boxes look very different, size 
and color.. since we are pausing the remaining refractor work until 1.0 is 
hardened, i wonder if we can style the old ones to match the new antd style? 
    
   <img width="490" alt="Screen Shot 2020-12-18 at 10 20 00 AM" 
src="https://user-images.githubusercontent.com/67837651/102647498-acdc3580-411a-11eb-80ed-9abd56ba4b2d.png";>
   
   other than that, it works and look good
   
   @rusackas @kgabryje 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org