hughhhh commented on a change in pull request #12130:
URL:
https://github.com/apache/incubator-superset/pull/12130#discussion_r546080371
##########
File path: superset/db_engine_specs/presto.py
##########
@@ -132,7 +132,8 @@ class PrestoEngineSpec(BaseEngineSpec): # pylint:
disable=too-many-public-metho
}
@classmethod
- def get_allow_cost_estimate(cls, version: Optional[str] = None) -> bool:
+ def get_allow_cost_estimate(cls, extra: Dict[str, Any]) -> bool:
+ version = extra.get("version")
return version is not None and StrictVersion(version) >=
StrictVersion("0.319")
Review comment:
one liner:
`return extra.get("version") and StrictVersion(version) >=
StrictVersion("0.319")`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
