suddjian commented on a change in pull request #10288:
URL:
https://github.com/apache/incubator-superset/pull/10288#discussion_r546192820
##########
File path: superset-frontend/src/explore/store.js
##########
@@ -69,13 +69,15 @@ export function applyDefaultFormData(inputFormData) {
const controlFormData = getFormDataFromControls(controlsState);
const formData = {};
- Object.keys(controlsState).forEach(controlName => {
- if (inputFormData[controlName] === undefined) {
- formData[controlName] = controlFormData[controlName];
- } else {
- formData[controlName] = inputFormData[controlName];
- }
- });
+ Object.keys(controlsState)
+ .concat(Object.keys(inputFormData))
Review comment:
Dynamically imported plugins don't have any controls state available
until after the plugin has loaded. This change makes it so that we use the
fields from the chart's form data instead of only using the controls.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
